Loop function in generateWait (generator.ts) never ends

[tomaszkunicki]

Description

When transition is processed (loop) the local variable (done) is not incremented in result loop function never ends.

Steps to check or reproduce

Check in the debugger. The line with callback is not executed.

[netil]

Hi @tomaszkunicki, could you provide precise reproducible example?

In a simple legend toggle transition, it works.

[tomaszkunicki]

I think this is the case when the tab is not visible. I think the assumption was the transition should be emptied.
If the function is called when the tab is not visible, it loops forever. It seems the generateWait is called even though the tab is not visible.
So, it works in regular condition, but when we lock the desktop (and tabs are hidden then) and after while I'm getting back to charts the browser processes millions of timers.

[tomaszkunicki]

I'm still investigating the issue. All I see that after a while I can get 100% utilization and 5 million of d3 timer tasks.

It seems that this fix works for me.

adremsoft@21d98b2

[netil]

I think this is the case when the tab is not visible. I think the assumption was the transition should be emptied.

Tested triggering some API to simulate, but even tab is hidden the callback called.
To prevent any situation, where the loop never ends, adding bulletproof code will prevent or mitigate.