fix(option): Fix inconsistency of padding #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor getting padding values by direction - Fix padding.bottom to follow from as other directions Ref naver#3426
netil
pushed a commit
to netil/billboard.js
that referenced
this pull request
Nov 6, 2023
Fix side-effect of naver#3433, where removed x axis tick overflow computation Ref naver#3499
netil
pushed a commit
to netil/billboard.js
that referenced
this pull request
Nov 6, 2023
Fix side-effect of naver#3433, where removed x axis tick overflow computation Ref naver#3499
netil
pushed a commit
to netil/billboard.js
that referenced
this pull request
Nov 8, 2023
Adjust top padding on rotated axis Adjust right padding for 'fit' mode with legend positioned at right Ref naver#3433
netil
added a commit
that referenced
this pull request
Nov 8, 2023
Adjust top padding on rotated axis Adjust right padding for 'fit' mode with legend positioned at right Ref #3433
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
## [3.10.3](3.10.2...3.10.3) (2023-11-08) ### Bug Fixes * **axis:** Fix x axis autorotate option applies ([e45eaf7](e45eaf7)), closes [#3433](#3433) [#3499](#3499) * **labels:** Fix data.labels rendering for ranged data ([a8ebdef](a8ebdef)), closes [#3495](#3495) * **option:** Fix rotated top padding ([048c4e2](048c4e2)), closes [#3433](#3433) * **tooltip:** Fix tooltip.format.value arg for bar range data ([c0f445e](c0f445e)), closes [#3507](#3507)
netil
pushed a commit
to netil/billboard.js
that referenced
this pull request
Nov 14, 2023
* **axis:** Fix x axis autorotate option applies ([e45eaf7](naver@e45eaf7)), closes [naver#3433](naver#3433) [naver#3499](naver#3499) * **labels:** Fix data.labels rendering for ranged data ([a8ebdef](naver@a8ebdef)), closes [naver#3495](naver#3495) * **option:** Fix rotated top padding ([048c4e2](naver@048c4e2)), closes [naver#3433](naver#3433) * **tooltip:** Fix tooltip.format.value arg for bar range data ([c0f445e](naver@c0f445e)), closes [naver#3507](naver#3507)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3426
Details