Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing x axis tick overflow since 3.10.0 #3499

Closed
michkami opened this issue Oct 30, 2023 · 1 comment
Closed

missing x axis tick overflow since 3.10.0 #3499

michkami opened this issue Oct 30, 2023 · 1 comment
Labels
bug

Comments

@michkami
Copy link
Collaborator

michkami commented Oct 30, 2023 •
edited
Loading

Description

With the rework of how padding is handled in #3433 the calculation of xAxisTickTextOverflow (which got added with #1250) got removed. Because of this overflow is not added to the right padding when x.axis.tick.autorotate = true and the text of one of the x axis ticks is longer than the width of the chart.

Before 3.10.0:
grafik

After 3.10.0:
grafik

Steps to check or reproduce

jsfiddle
@netil
Copy link
Member

netil commented Oct 30, 2023

@michkami thanks for the report.
I'll check that.

netil pushed a commit to netil/billboard.js that referenced this issue Nov 6, 2023
fix(axis): Fix x axis autorotate option applies
54d54d1 
Fix side-effect of naver#3433, where removed x axis tick overflow
computation

Ref naver#3499
@netil netil mentioned this issue Nov 6, 2023
Merged
netil pushed a commit to netil/billboard.js that referenced this issue Nov 6, 2023
fix(axis): Fix x axis autorotate option applies
f2579ab 
Fix side-effect of naver#3433, where removed x axis tick overflow
computation

Ref naver#3499
@netil netil closed this as completed in e45eaf7 Nov 6, 2023
github-actions bot pushed a commit that referenced this issue Nov 8, 2023
@semantic-release-bot
chore(release): 3.10.3 [skip ci]
1829c0e 
## [3.10.3](3.10.2...3.10.3) (2023-11-08)

### Bug Fixes

* **axis:** Fix x axis autorotate option applies ([e45eaf7](e45eaf7)), closes [#3433](#3433) [#3499](#3499)
* **labels:** Fix data.labels rendering for ranged data ([a8ebdef](a8ebdef)), closes [#3495](#3495)
* **option:** Fix rotated top padding  ([048c4e2](048c4e2)), closes [#3433](#3433)
* **tooltip:** Fix tooltip.format.value arg for bar range data ([c0f445e](c0f445e)), closes [#3507](#3507)
netil pushed a commit to netil/billboard.js that referenced this issue Nov 14, 2023
@semantic-release-bot
chore(release): 3.10.3 [skip ci]
b6bae4b 
* **axis:** Fix x axis autorotate option applies ([e45eaf7](naver@e45eaf7)), closes [naver#3433](naver#3433) [naver#3499](naver#3499)
* **labels:** Fix data.labels rendering for ranged data ([a8ebdef](naver@a8ebdef)), closes [naver#3495](naver#3495)
* **option:** Fix rotated top padding  ([048c4e2](naver@048c4e2)), closes [naver#3433](naver#3433)
* **tooltip:** Fix tooltip.format.value arg for bar range data ([c0f445e](naver@c0f445e)), closes [naver#3507](naver#3507)
@michkami michkami mentioned this issue Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netil @michkami