-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better tooltip for ranged bar charts #3507
Comments
It isn't called twice. It will be called once with array data. |
Here is the line i'm thinking about for
It would be nice if valueFormatter is called with [start, end] in order to show something other than I would like to show the absolute value for each bar to acheive something like a waterfall chart, showing the absolute values for each bar in both datalabels and tooltip. #3495 solved the same issue for me for data labels |
Hmm... there was a misunderstanding here. I was pointing that not called twice for Updating the way that worked, could derive backward compatibility issue. I'm not sure this is a bug or enhancement. |
- Make format function called once for range(array) data type - Update on defaultValueFormat to handle array type value also. Ref naver#3507
## [3.10.3](3.10.2...3.10.3) (2023-11-08) ### Bug Fixes * **axis:** Fix x axis autorotate option applies ([e45eaf7](e45eaf7)), closes [#3433](#3433) [#3499](#3499) * **labels:** Fix data.labels rendering for ranged data ([a8ebdef](a8ebdef)), closes [#3495](#3495) * **option:** Fix rotated top padding ([048c4e2](048c4e2)), closes [#3433](#3433) * **tooltip:** Fix tooltip.format.value arg for bar range data ([c0f445e](c0f445e)), closes [#3507](#3507)
Agree, in the case of |
well the update only affect for bar ranged type. It could affect some compatibility issue on that type, but will not for other types. |
* **axis:** Fix x axis autorotate option applies ([e45eaf7](naver@e45eaf7)), closes [naver#3433](naver#3433) [naver#3499](naver#3499) * **labels:** Fix data.labels rendering for ranged data ([a8ebdef](naver@a8ebdef)), closes [naver#3495](naver#3495) * **option:** Fix rotated top padding ([048c4e2](naver@048c4e2)), closes [naver#3433](naver#3433) * **tooltip:** Fix tooltip.format.value arg for bar range data ([c0f445e](naver@c0f445e)), closes [naver#3507](naver#3507)
Description
I think ranged bar chart tooltip should be changed to the same way #3495 (comment) has been implemented.
Instead of calling
tooltip.format.value
twice (once with start value and once with end value) it should be called once with value as an array [start, end].The text was updated successfully, but these errors were encountered: