Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Cannot read property 'tagName' of undefined #340

Closed
adsee42 opened this issue Jun 1, 2020 · 3 comments
Closed

React: Cannot read property 'tagName' of undefined #340

adsee42 opened this issue Jun 1, 2020 · 3 comments
Labels
bug

Comments

@adsee42
Copy link

adsee42 commented Jun 1, 2020 •
edited
Loading

Description

https://codesandbox.io/s/eidk8

I think this is the official example for React.
I didn't change anything.
It shows this error when page opened.

Only error when using loading property.
If I comment the line // loading={<div className="loading">Loading...</div>}, no error but also no loading component shown.
@daybrush
Copy link
Member

daybrush commented Jun 1, 2020

@adsee42

Oh. Thank you. I'll fix it soon.

@daybrush daybrush added the bug label Jun 1, 2020
@daybrush daybrush mentioned this issue Jun 2, 2020
Closed
daybrush added a commit to daybrush/egjs-infinitegrid that referenced this issue Jun 2, 2020
@daybrush
fix: fix loading element for first mount naver#340
a74c687
@daybrush daybrush mentioned this issue Jun 2, 2020
Merged
@daybrush
Copy link
Member

daybrush commented Jun 4, 2020

@adsee42

react-infinitegrid 3.0.5 is released. Check it again.

@adsee42
Copy link
Author

adsee42 commented Jun 5, 2020

It worked! Thank you!

@adsee42 adsee42 closed this as completed Jun 5, 2020
daybrush added a commit that referenced this issue Jun 12, 2020
@daybrush
fix: fix loading element for first mount #340 (#342)
9f6ac1a 
* fix: fix loading element for first mount #340

* test: test travis' node version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daybrush @adsee42