Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix loading element for first mount #340 #342

Merged
merged 2 commits into from
Jun 12, 2020
Merged

fix: fix loading element for first mount #340 #342

merged 2 commits into from
Jun 12, 2020

Conversation

daybrush
Copy link
Member

@daybrush daybrush commented Jun 2, 2020

Issue

#340

Details

@daybrush daybrush requested review from mixed and WoodNeck June 2, 2020 04:42
@coveralls
Copy link

coveralls commented Jun 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 90.78% when pulling c3ca58c on daybrush:loading#340 into 2d6c7d2 on naver:master.

WoodNeck
WoodNeck approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@WoodNeck WoodNeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mixed
mixed reviewed Jun 2, 2020
View reviewed changes
Copy link
Member

@mixed mixed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Is test code unnecessary?

@daybrush
Copy link
Member Author

daybrush commented Jun 4, 2020

@mixed

This is react code, so there is no test code yet.

WoodNeck
WoodNeck approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@WoodNeck WoodNeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@daybrush daybrush merged commit 9f6ac1a into naver:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixed mixed mixed approved these changes

@WoodNeck WoodNeck WoodNeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daybrush @coveralls @mixed @WoodNeck