Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments cut off if longer than wrapper #637

Closed
ItsNoted opened this issue Nov 17, 2020 · 8 comments
Closed

Comments cut off if longer than wrapper #637

ItsNoted opened this issue Nov 17, 2020 · 8 comments

Comments

@ItsNoted
Copy link

Comments cut off if they are longer than the wrapper. This could be an issue for audiobooks with large descriptions.

See this image.
https://prnt.sc/vktgii

@deluan
Copy link
Member

deluan commented Nov 17, 2020

Thanks for the report.

Should we do the same as other platforms and strip line breaks from the comment?

@metalheim
Copy link
Contributor

metalheim commented Nov 22, 2020

I can confirm the problem (also had this with an audiobook with a very long comment).

@deluan
Its actually enough to remove the CSS property "white-space: nowrap;" from the wrapper and the text will flow nicely.

Default (with white-space: nowrap)

image

Exptected behaviour (removed white-space: nowrap)

image

Also, the MuiCard elements dont overflow beyond the viewport anymore :)

EDIT: maybe limit the wrappers "max-height" to some few lines and have it "overflow:auto" to avoid huge comments to break the layout in the vertical direction.

@deluan deluan closed this as completed in ab856e3 Nov 27, 2020
@sergio-ns
Copy link

sergio-ns commented Feb 13, 2021

Hello,
I just upgraded to v0.39.0 on docker and #637 seems to still be there.
Tried both on Firefox 85, Chrome 88 and Edge.
Thanks!
(PS loving increasingly Navidrome by the day)

2021-02-13 11_53_19-Navidrome

2021-02-13 11_52_17-Navidrome

@deluan
Copy link
Member

deluan commented Feb 13, 2021

Thanks @sergio-ns . Can you send me one song from this album, that contain this comment?

@sergio-ns
Copy link

Sent to your email address

@deluan
Copy link
Member

deluan commented Feb 15, 2021

@sergio-ns Navidrome actually enables expanding the comments in this case, you just have to click on the comment. The issue is that there's no visual cues for that:
Screen Recording 2021-02-15 at 1 35 53 PM

I'll take a look at that. If you have any more comments, please open a new GH issue, as this one is closed.

@sergio-ns
Copy link

Thanks for clarifying

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants