feat(UI) : Extract urls from comments and link them to their correspoding sites - #1053

[MoulinaPradhan]

Closes- #1053

Used an npm package react-anchorme, which links the comment URLs to their corresponding site.

BREAKING CHANGE

The changes are made in the AlbumDetails file in the UI folder. There are changes in the package.json file due to the installation of the package react-anchorme.

20210612_110739.mp4

[deluan]

Hey @MoulinaPradhan, thanks for taking a stab at this!

I took a quick look and I see a couple of issues:

1. You forgot to push the changes to the package.json file
2. The links should have a "link" color.

But most important: I don't think it is worth to add a new dependency just for this. It would make more sense to create a simple component which could be used in a similar fashion as <Anchorme/>, and this component would basically uses the regex suggested by @metalheim here, and replace matches with a <Link> component, that already handles the styling for us.

What do you think?

[MoulinaPradhan]

Hi, I have created a component CommentLink, that works in a similar way like and made the changes as suggested.

nav.mp4

[dheerajdlalwani]

Hey @MoulinaPradhan, are you continuing on this PR?

[deluan]

Hey @MoulinaPradhan, sorry for not giving feedback on this before. The main issue with your implementation is that the comment can contain a mix of text and URL(s). Ex:

We are the best band in town!
Our website: https://theband.com
Buy our music: https://bandcamp.com/theband

In your implementation, you are considering that the comment only contains one URL and nothing more. That would not work with the example above.

[deluan]

I've finished this up in c530ccf. Thanks for your effort!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.