Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error when input channel is not corpus #56

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Conversation

f-hafner
Copy link
Collaborator

@f-hafner f-hafner commented Apr 4, 2024

Issue

Workaround to fix #42

Description of changes
  • Added an Error property to the actor analysis widget
  • raises error when wrong input type for stories. The error only goes away when the right input for Stories is provided.
Questions
  • should we also check input types for story_elements? What is the exact control flow then, with the if story_elements is not None
  • should we also do the same for the action analysis widget?
Includes
  • Code changes

@kodymoodley kodymoodley marked this pull request as ready for review April 4, 2024 14:25
@kodymoodley
Copy link
Contributor

kodymoodley commented Apr 4, 2024

Nice @f-hafner! The message works for the inputs / outputs you give in your example. This case:

image

...But it doesn't work in this case:

image

It should throw an error message there too.

There is another minor issue, the error message does not go away once you correct the input:
image

Otherwise I think your general solution is very nice and practical!

Regarding your questions, indeed also check for story_elements and also apply the same solution to action widget.

@f-hafner
Copy link
Collaborator Author

f-hafner commented Apr 9, 2024

@kodymoodley , I fixed as you suggested, both for Actors and Actions.

There is a message residual_error in error_handling.py. It was intended to capture other errors when data are processed, but it's dfficult to capture all edge cases, and I'm not sure it's the best way to deal with such errors anyway.
If you disagree, we can discuss how this should be incorporated.
If you want me to remove the message, let me know.
Otheriwse this can be merged from my side.

@kodymoodley kodymoodley merged commit 1b94d3e into master Apr 18, 2024
0 of 9 checks passed
@kodymoodley kodymoodley deleted the useful-defaults branch April 18, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make useful defaults for links?
2 participants