Skip to content

Commit

Permalink
fix:circleci: do not download build environment for sanity check (#891)
Browse files Browse the repository at this point in the history
and reenable xml lint for all configurations shipped.
  • Loading branch information
metalstrolch committed Oct 1, 2019
1 parent ac49d27 commit 7b4c887
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- checkout
- run:
name: Setup requirements
command: bash scripts/setup_common_requirements.sh
command: bash scripts/setup_sanitycheck_requirements.sh
- run:
name: run sanity check script
command: bash scripts/ci_sanity_checks.sh
Expand Down
12 changes: 11 additions & 1 deletion navit/navit.dtd
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,14 @@
<!ATTLIST log flush_size CDATA #IMPLIED>
<!ATTLIST log flush_time CDATA #IMPLIED>
<!ATTLIST log attr_types CDATA #IMPLIED>
<!ELEMENT navit (graphics,gui+,log*,osd*,traffic*,vehicle*,tracking?,vehicleprofile*,route,navigation,speech,mapset+,layer+,layout+) >
<!ELEMENT navit (graphics,gui+,log*,osd*,traffic*,vehicle*,tracking?,vehicleprofile*,route,navigation,speech,mapset+,layer+,xi:include+,layout+) >
<!ATTLIST navit center CDATA #REQUIRED>
<!ATTLIST navit zoom CDATA #REQUIRED>
<!ATTLIST navit tracking CDATA #REQUIRED>
<!ATTLIST navit orientation CDATA #REQUIRED>
<!ATTLIST navit recent_dest CDATA #IMPLIED>
<!ATTLIST navit drag_bitmap CDATA #IMPLIED>
<!ATTLIST navit default_layout CDATA #IMPLIED>
<!ELEMENT gui ANY>
<!ATTLIST gui type CDATA #REQUIRED>
<!ATTLIST gui menubar CDATA #IMPLIED>
Expand Down Expand Up @@ -107,6 +108,10 @@
<!ATTLIST layout font CDATA #IMPLIED>
<!ATTLIST layout daylayout CDATA #IMPLIED>
<!ATTLIST layout nightlayout CDATA #IMPLIED>
<!ATTLIST layout icon_w CDATA #IMPLIED>
<!ATTLIST layout icon_h CDATA #IMPLIED>
<!ATTLIST layout underground_alpha CDATA #IMPLIED>
<!ATTLIST layout xmlns:xi CDATA #IMPLIED>
<!ELEMENT layer (itemgra*)>
<!ATTLIST layer enabled CDATA #IMPLIED>
<!ATTLIST layer name CDATA #IMPLIED>
Expand All @@ -127,22 +132,26 @@
<!ATTLIST itemgra speed_range CDATA #IMPLIED>
<!ELEMENT polygon (coord*)>
<!ATTLIST polygon color CDATA #REQUIRED>
<!ATTLIST polygon oneway CDATA #IMPLIED>
<!ELEMENT polyline (coord*)>
<!ATTLIST polyline color CDATA #REQUIRED>
<!ATTLIST polyline width CDATA #IMPLIED>
<!ATTLIST polyline dash CDATA #IMPLIED>
<!ATTLIST polyline offset CDATA #IMPLIED>
<!ATTLIST polyline radius CDATA #IMPLIED>
<!ATTLIST polyline oneway CDATA #IMPLIED>
<!ELEMENT text EMPTY>
<!ATTLIST text text_size CDATA #REQUIRED>
<!ATTLIST text color CDATA #IMPLIED>
<!ATTLIST text background_color CDATA #IMPLIED>
<!ATTLIST text oneway CDATA #IMPLIED>
<!ELEMENT circle (coord*)>
<!ATTLIST circle color CDATA #REQUIRED>
<!ATTLIST circle radius CDATA #REQUIRED>
<!ATTLIST circle width CDATA #IMPLIED>
<!ATTLIST circle text_size CDATA #IMPLIED>
<!ATTLIST circle background_color CDATA #IMPLIED>
<!ATTLIST circle oneway CDATA #IMPLIED>
<!ELEMENT icon EMPTY>
<!ATTLIST icon src CDATA #REQUIRED>
<!ATTLIST icon w CDATA #IMPLIED>
Expand All @@ -152,6 +161,7 @@
<!ELEMENT arrows EMPTY>
<!ATTLIST arrows color CDATA #REQUIRED>
<!ATTLIST arrows width CDATA #IMPLIED>
<!ATTLIST arrows oneway CDATA #IMPLIED>
<!ELEMENT image EMPTY>
<!ELEMENT xi:include EMPTY>
<!ATTLIST xi:include href CDATA #IMPLIED>
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci_sanity_checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ for f in $(git diff --name-only ${interval} | sort -u); do
check_diff
fi

if [[ "${f}" == "navit/navit_shipped.xml" ]]; then
if [[ "${f: -11}" == "shipped.xml" ]]; then
echo "[INFO] Checking for compliance with the DTD using xmllint on ${f}..."
xmllint --noout --dtdvalid navit/navit.dtd "$f"
rc=$?
Expand Down
4 changes: 4 additions & 0 deletions scripts/setup_sanitycheck_requirements.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh
set -e

apt-get update && apt-get install -y git astyle libxml2-utils file

0 comments on commit 7b4c887

Please sign in to comment.