Rework the Binfile driver #1254
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is completely undocumented and mixes data access via multiple ways. We want to focus on one thing only
jkoan
force-pushed
the
remove_binfile_download
branch
from
8dfc3d5
to
018ecf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binfile driver is probably our most important driver regarding map data.
The driver should be split in multiple units that are as self contained as possible. This will also help with the understanding as currently the binfile map-driver mixes being a downloader, a zip implementation, a tile implementation and probably something else.
Things to take care of:
Why: It is completely undocumented and mixes data access via multiple ways. We want to focus on one thing only per Plugin