android native app

1) fixed issue with deleting items on firebase (and adapter going out of sync) 2) fixed layout issue with todo list not being on top of the edittext
nazmulidris · Jan 13, 2017 · 0a4ea57 · 0a4ea57
1 parent 387e606
commit 0a4ea57
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/mobile_android_native/app/src/main/java/com/r3bl/todo_app/ui/todo/TodoListAdapter.java b/mobile_android_native/app/src/main/java/com/r3bl/todo_app/ui/todo/TodoListAdapter.java
@@ -14,7 +14,7 @@
  * Created by nazmul on 1/12/17.
  */
 public class TodoListAdapter extends RecyclerView.Adapter<TodoListAdapter.ViewHolder> {
-private final App                      _ctx;
+private final App _ctx;
 
 public TodoListAdapter(App ctx) {
   this._ctx = ctx;
@@ -34,8 +34,10 @@ public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
 @Override
 public void onBindViewHolder(ViewHolder holder, int position) {
   Data.TodoItem row = _ctx.getReduxState().data.todoArray.get(position);
-  holder.item.setText(row.item);
-  holder.done.setText(String.valueOf(row.done));
+  if (row != null) {
+    holder.item.setText(row.item);
+    holder.done.setText(String.valueOf(row.done));
+  }
 }
 
 @Override

diff --git a/mobile_android_native/app/src/main/res/layout/todo_fragment.xml b/mobile_android_native/app/src/main/res/layout/todo_fragment.xml
@@ -4,13 +4,6 @@
     android:layout_height="match_parent"
     android:orientation="vertical">
 
-    <android.support.v7.widget.RecyclerView
-        android:id="@+id/todo_list_recyclerview"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:layout_alignParentStart="true"
-        android:layout_above="@+id/todo_text_input" />
-
     <EditText
         style="@style/Divider"
         android:id="@+id/todo_text_input"
@@ -26,4 +19,12 @@
         android:imeOptions="actionGo"
         />
 
+    <android.support.v7.widget.RecyclerView
+        android:layout_above="@+id/todo_text_input"
+        android:id="@+id/todo_list_recyclerview"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_alignParentTop="true"
+        android:layout_alignParentStart="true" />
+
 </RelativeLayout>