fix: fix android chrome support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes some issues in Android Chrome. Android Chrome doesn't send keypress event, so we rely on input events instead. The old input event handler code was basically duplicating code in the keypress handler, but it wasn't as robust, especially after we added support for natural mode. For example it assumed the cursor was always at the end of the input, so it isn't possible to add or delete a digit in the middle of the number. It doesn't allow you to add digits at all in natural mode. The new code delegates to the existing keypress handler when adding digits, resulting in consistent functionality with desktop browsers. The algorithm is simple. Figure out what character was added, restore the old string, then call handleKeyPress with the new character. I also tweaked the remove logic by setting the selection index before calling remove number, so it's now possible to remove a digit at any index. In addition to adding unit tests, I tested this on an Android Simulator and my personal android device Addresses issues #90 and #100
|
@nbfontana please check. Thanks |
|
Looking into it |
|
@jlabanca Sorry if I'm late on this one and other updates in ngx-currency. I'm actually thinking in migrating this repository to a Currency org with some other collaborators, would you be interested? If so, you could e-mail me (e-mail on profile) with you discord or something so we can organize it... No pressure Ahaha |
|
This change is live at ngx-currency@2.4.0 |
|
Thanks for the review. I sent you an email with my discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes some issues in Android Chrome. Android Chrome doesn't send keypress event, so we rely on input events instead. The old input event handler code was basically duplicating code in the keypress handler, but it wasn't as robust, especially after we added support for natural mode. For example it assumed the cursor was always at the end of the input, so it isn't possible to add or delete a digit in the middle of the number. It doesn't allow you to add digits at all in natural mode.
The new code delegates to the existing keypress handler when adding digits, resulting in consistent functionality with desktop browsers. The algorithm is simple. Figure out what character was added, restore the old string, then call handleKeyPress with the new character.
I also tweaked the remove logic by setting the selection index before calling remove number, so it's now possible to remove a digit at any index.
In addition to adding unit tests, I tested this on an Android Simulator and my personal android device
Addresses issues #90 and #100.
cc: @nbfontana