Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to onnxruntime 1.6.0 #59

Merged
merged 5 commits into from
Feb 23, 2021

Conversation

marshallpierce
Copy link
Contributor

Re-ran cargo build --package onnxruntime-sys --features generate-bindings as per comment in build.rs.

Re-ran `cargo build --package onnxruntime-sys --features generate-bindings` as per comment in build.rs.
@nbigaouette
Copy link
Owner

I think the bindings need to be generated on Windows and Linux separately. Are you able to do so? If not I'll see if I can get back to this...

@marshallpierce
Copy link
Contributor Author

I don't have access to a windows box. If you don't beat me to it, I'll see if I can get it working on Microsoft's free IE testing VMs.

@nbigaouette
Copy link
Owner

For Linux Docker is fine. For Windows I used this: https://github.com/nbigaouette/windows_vagrant_rust

I can push a commit if you want.

@marshallpierce
Copy link
Contributor Author

Please do; I'm on mediocre hotel internet so VMs take forever to download.

@nbigaouette
Copy link
Owner

I raise you my crappy laptop that chokes on VMs 😂

Got the Linux bindings generated. Doing the windows ones now.

I'm not sure how to handle the git repo though. Since you forked my repo, I can't push to your branch. So while I have the commit I can't include it in this PR... or can I?

@marshallpierce
Copy link
Contributor Author

I granted you write access to my fork; it should let you push now

@nbigaouette
Copy link
Owner

Thanks! Windows bindings are building...

@codecov-io
Copy link

Codecov Report

Merging #59 (3665cb0) into master (388e1b3) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   14.55%   14.58%   +0.03%     
==========================================
  Files          18       18              
  Lines         962      960       -2     
==========================================
  Hits          140      140              
+ Misses        822      820       -2     
Impacted Files Coverage Δ
...runtime-sys/src/generated/macos/x86_64/bindings.rs 0.00% <ø> (ø)
onnxruntime/src/environment.rs 89.83% <ø> (ø)
onnxruntime/src/error.rs 57.14% <0.00%> (ø)
onnxruntime/src/session.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ada2e...3665cb0. Read the comment docs.

Copy link
Owner

@nbigaouette nbigaouette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants