-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to onnxruntime 1.6.0 #59
Conversation
Re-ran `cargo build --package onnxruntime-sys --features generate-bindings` as per comment in build.rs.
03cea1d
to
5b8eb27
Compare
I think the bindings need to be generated on Windows and Linux separately. Are you able to do so? If not I'll see if I can get back to this... |
I don't have access to a windows box. If you don't beat me to it, I'll see if I can get it working on Microsoft's free IE testing VMs. |
For Linux Docker is fine. For Windows I used this: https://github.com/nbigaouette/windows_vagrant_rust I can push a commit if you want. |
Please do; I'm on mediocre hotel internet so VMs take forever to download. |
I raise you my crappy laptop that chokes on VMs 😂 Got the Linux bindings generated. Doing the windows ones now. I'm not sure how to handle the git repo though. Since you forked my repo, I can't push to your branch. So while I have the commit I can't include it in this PR... or can I? |
I granted you write access to my fork; it should let you push now |
Thanks! Windows bindings are building... |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 14.55% 14.58% +0.03%
==========================================
Files 18 18
Lines 962 960 -2
==========================================
Hits 140 140
+ Misses 822 820 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Re-ran
cargo build --package onnxruntime-sys --features generate-bindings
as per comment in build.rs.