forked from joemphilips/DotNetLightning
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - track more information about commit history #22
Open
canndrew
wants to merge
13
commits into
nblockchain:geewalletLightningMilestone3
Choose a base branch
from
canndrew:new-lightning-milestone3-tx-identification
base: geewalletLightningMilestone3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP - track more information about commit history #22
canndrew
wants to merge
13
commits into
nblockchain:geewalletLightningMilestone3
from
canndrew:new-lightning-milestone3-tx-identification
Commits on Nov 13, 2020
-
- LICENSE: change from MIT to AGPL (.Kiss fork) - Change package name suffix from .Core to .Kiss (skipping native build)
Configuration menu - View commit details
-
Copy full SHA for bd268cd - Browse repository at this point
Copy the full SHA bd268cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 151599c - Browse repository at this point
Copy the full SHA 151599cView commit details
Commits on Jan 7, 2021
-
It seems that these attributes can cause this compilation error in F#4.0: error FS0927: The kind of the type specified by its attributes does not match the kind implied by its definition Newer versions of F# (like 4.5 or even newer, like the one being used by .NETCore to build the binary that is later published in nuget) allow compiling this code with no issues, but if you reference the generated assembly later from an old F# compiler, it could generate exceptions at runtime, e.g.: System.BadFormatImageException (or other types) whose inner exception could be the following: System.TypeLoadException : Could not load type of field 'GWallet.Backend.UtxoCoin.Lightning.SerializedChannel:MinSafeDepth@' (6) due to: Expected reference type but got type kind 17 FSharp.Core's Result type is also affected by this so in this commit we create a replacement for it that is only used in the BouncyCastle build (which we now rename as 'Portability' build). Forward-ported from a4a59d0 Co-authored-by: Andres G. Aragoneses <knocte@gmail.com> Co-authored-by: Andrew Cann <shum@canndrew.org>
Configuration menu - View commit details
-
Copy full SHA for 58763fe - Browse repository at this point
Copy the full SHA 58763feView commit details -
Re-add txout shuffling work-around (joemphilips#13)
This NBitcoin issue: MetacoSA/NBitcoin#931 somehow still hasn't been fixed properly (our geewallet CI still encounters it, surprisingly). So let's reapply the workaround[1] that we had removed[2]. [1] joemphilips@d813a97 [2] joemphilips@256893c
Configuration menu - View commit details
-
Copy full SHA for 2573294 - Browse repository at this point
Copy the full SHA 2573294View commit details -
Utils: OptionCE and SeqConsumerCE comp expressions
ResultUtils: new OptionCE, a computation expression for creating options, similar to the result computation expression which DNL already has. Core.Utils: new SeqConsumerCE, a computation expression which makes it easy to write code which consumes a sequence, one element at a time.
Configuration menu - View commit details
-
Copy full SHA for 361a348 - Browse repository at this point
Copy the full SHA 361a348View commit details
Commits on Jan 8, 2021
-
Add channel force-closing support
In order to support this, this commit adds two elements: 1) CommitmentToLocalExtension This is an NBitcoin BuilderExtension that tells NBitcoin.TransactionBuilder how to recognise and sign to_local txouts from lightning commitment transactions. This is needed for force-closing to spend to_local outputs. 2) tryGetFundsFromLocalCommitmentTx When force-closing a channel this function is used to recover funds from our commitment transaction. It generates a transaction which can be broadcast once the timelock on the to_local output has expired.
Configuration menu - View commit details
-
Copy full SHA for d23e1c1 - Browse repository at this point
Copy the full SHA d23e1c1View commit details -
Add tryGetFundsFromRemoteCommitmentTx function
This function recovers funds from the to_remote output of a remote commitment tx which has been broadcast to the blockchain.
Configuration menu - View commit details
-
Copy full SHA for 1a64d1a - Browse repository at this point
Copy the full SHA 1a64d1aView commit details
Commits on Jan 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 39075f0 - Browse repository at this point
Copy the full SHA 39075f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 817550c - Browse repository at this point
Copy the full SHA 817550cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1267736 - Browse repository at this point
Copy the full SHA 1267736View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab475a8 - Browse repository at this point
Copy the full SHA ab475a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0612949 - Browse repository at this point
Copy the full SHA 0612949View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95e95b6 - Browse repository at this point
Copy the full SHA 95e95b6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.