Network: TorStream should inherit IO.Stream #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knocte commitLint seems to be broken |
aarani
force-pushed
the
inheritStream
branch
7 times, most recently
from
d065128
to
91bcba9
Compare
knocte
reviewed
Apr 11, 2023
|
|
aarani
force-pushed
the
inheritStream
branch
2 times, most recently
from
8383500
to
00ce56a
Compare
This commit adds IO.Stream as a parent class to TorStream this extremely helps with compatibility and lowers the number of necessary changes to end users' code.
This commit removes the chunk helper function in favor the already existing F# method named ChunkBySize, not sure why I didn't find it before.
aarani
force-pushed
the
inheritStream
branch
2 times, most recently
from
f28e2ff
to
730edf6
Compare
|
I rebased this PR, is there anything else here @knocte ? |
knocte
reviewed
Apr 15, 2023
This test is mostly for flexing TorStream's compatiblity with SslStream. Also apparently some web servers don't include Content-Encoding header in that case we just assume that there's no special encoding.
knocte
approved these changes
Apr 16, 2023
|
@knocte I can't approve my own pull request so I can't merge it |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds IO.Stream as a parent class
to TorStream this extremely helps with compatibility
and lowers the number of necessary changes to end
users' code.