-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix commitlint and create README file #57
Conversation
README.md
Outdated
------------------------------- | ||
[![Build Status](https://github.com/nblockchain/NOnion/actions/workflows/CI.yml/badge.svg?branch=master&event=push)](https://github.com/nblockchain/NOnion/actions/workflows/CI.yml) | ||
|
||
_Unofficial_ work in progress TOR client library implemented in F# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say dotnet TOR-client library (implemented in F#)
, otherwise C# devs might think it's only consumable from F#
README.md
Outdated
Install via NuGet | ||
|
||
``` | ||
> Install-Package NOnion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please note, this is not a command that works in any terminal, let's add more specific instructions here
README.md
Outdated
* [Afshin Arani](https://github.com/aarani) | ||
* [knocte](https://github.com/knocte) | ||
* [Parham Saremi](https://github.com/parhamsaremi) | ||
* [webwarrior-ws](https://github.com/webwarrior-ws) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this list might get outdated easily, how about adding a link to https://github.com/nblockchain/NOnion/graphs/contributors instead?
README.md
Outdated
|
||
# License | ||
|
||
MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DRY, let's simply add a link to the License file
Last thing, maybe bring the |
This commit also updates the LICENSE file.
Done |
It's time we add a good README, I keep blanking on how to make the documentation
It's too hard to do a simple connection to TOR (directory bootstrap, connect guard, create a circuit, open stream)
#56 is a small change in the path to making using NOnion easier either we merge README without documentation
or we DRAFT this and wait until I make some high-level APIs for easier usage.
Ah I also updated the year in LICENSE, it wasn't touched in 2 years.