Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix commitlint and create README file #57

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

aarani
Copy link
Collaborator

@aarani aarani commented Apr 8, 2023

It's time we add a good README, I keep blanking on how to make the documentation
It's too hard to do a simple connection to TOR (directory bootstrap, connect guard, create a circuit, open stream)
#56 is a small change in the path to making using NOnion easier either we merge README without documentation
or we DRAFT this and wait until I make some high-level APIs for easier usage.

Ah I also updated the year in LICENSE, it wasn't touched in 2 years.

LICENSE Show resolved Hide resolved
README.md Outdated
-------------------------------
[![Build Status](https://github.com/nblockchain/NOnion/actions/workflows/CI.yml/badge.svg?branch=master&event=push)](https://github.com/nblockchain/NOnion/actions/workflows/CI.yml)

_Unofficial_ work in progress TOR client library implemented in F#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say dotnet TOR-client library (implemented in F#), otherwise C# devs might think it's only consumable from F#

README.md Outdated
Install via NuGet

```
> Install-Package NOnion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please note, this is not a command that works in any terminal, let's add more specific instructions here

README.md Outdated
* [Afshin Arani](https://github.com/aarani)
* [knocte](https://github.com/knocte)
* [Parham Saremi](https://github.com/parhamsaremi)
* [webwarrior-ws](https://github.com/webwarrior-ws)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list might get outdated easily, how about adding a link to https://github.com/nblockchain/NOnion/graphs/contributors instead?

README.md Outdated

# License

MIT License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY, let's simply add a link to the License file

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@knocte
Copy link
Member

knocte commented Apr 11, 2023

Last thing, maybe bring the CI: fix commitlint commit to this PR since this one is more likely to be merged first?

This commit also updates the LICENSE file.
@aarani
Copy link
Collaborator Author

aarani commented Apr 11, 2023

Last thing, maybe bring the CI: fix commitlint commit to this PR since this one is more likely to be merged first?

Done

@aarani aarani changed the title DRAFT: Create README and update LICENSE README: create README file Apr 11, 2023
@aarani aarani marked this pull request as ready for review April 11, 2023 14:42
@aarani aarani changed the title README: create README file fix commitlint and create README file Apr 11, 2023
@knocte knocte merged commit 737ac26 into nblockchain:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants