This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
[WIP] detect overlong/surrogate utf8 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
reviewed
Jul 19, 2018
naxsi_src/naxsi_utils.c
Outdated
|
|
||
| /* unescape routine : | ||
| - returns number of nullbytes present | ||
| - returns -1 if overlong utf8 sequence |
jvoisin
reviewed
Jul 19, 2018
| if (ngx_utf8_check(name) != NULL) { | ||
| ngx_http_apply_rulematch_v_n(&nx_int__bad_utf8, ctx, req, NULL, NULL, zone, 1, 1); | ||
| return (0); | ||
| } |
wargio
reviewed
Jul 20, 2018
naxsi_src/naxsi_utils.c
Outdated
| /* 110XXXXx 10xxxxxx */ | ||
| if ((s[1] & 0xc0) != 0x80 || | ||
| (s[0] & 0xfe) == 0xc0) /* overlong? */ | ||
| return s; |
There was a problem hiding this comment.
Add braces {} on that else if
naxsi_src/naxsi_utils.c
Outdated
| (s[0] == 0xf0 && (s[1] & 0xf0) == 0x80) || /* overlong? */ | ||
| (s[0] == 0xf4 && s[1] > 0x8f) || s[0] > 0xf4) /* > U+10FFFF? */ | ||
| return s; | ||
| else |
naxsi_src/naxsi_utils.c
Outdated
| else | ||
| s += 4; | ||
| } | ||
| else |
jvoisin
reviewed
Jul 20, 2018
naxsi_src/naxsi_utils.c
Outdated
|
|
||
|
|
||
| /* | ||
| unescape routine : |
There was a problem hiding this comment.
How can you return two values in a int ;)
added 2 commits
July 24, 2018 11:49
jvoisin
approved these changes
Jul 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a generic internal rule associated to detection of overlong/surrogate utf8