Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reported mapping counts between ontologies are inconsistent and higher than the actual counts #115

Closed
mdorf opened this issue Mar 13, 2021 · 2 comments

Comments

@mdorf
Copy link
Member

mdorf commented Mar 13, 2021

For example, the reported number of mappings between MONDO and DOID is significantly higher than the actual number:

Screen Shot 2021-03-13 at 12 29 40 PM

The real number of mappings between MONDO and DOID is 7825.

The mapping counts reported are frequently not reciprocal between two ontologies. For example:

DOID Ontology

Screen Shot 2021-03-13 at 12 45 14 PM

NIFSTD Ontology

Screen Shot 2021-03-13 at 12 44 53 PM

The real number of mappings between DOID and NIFSTD is 19552.

@graybeal
Copy link

graybeal commented Apr 29, 2021

This problem is no longer an issue for these two ontologies, thanks to the work recently done. The number of mappings from DOID -> NIFSTD and from NIFSTD -> DOID are both 17735, and that matches the number shown in the pop-up windows (344 pages @ 50 per page + 35 on the last page), and the numbers shown at http://data.bioontology.org/mappings/statistics/ontologies/DOID and http://data.bioontology.org/mappings/statistics/ontologies/NIFSTD.

I'm not sure on what basis the 'real number of mappings' is listed as 19552; I suspect that includes a significant number of duplicates which were also eliminated during the recent changes.

@mdorf
Copy link
Member Author

mdorf commented Apr 30, 2021

The script that used to generate mapping counts had a bug that used graphs from multiple submissions of the same ontology to generate mappings, resulting in duplicates. The bug is now fixed, so the mapping counts are generated only between the latest submissions of ontologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants