Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect mapping count statistics generated for some ontologies #94

Closed
mdorf opened this issue Jul 12, 2019 · 3 comments
Closed

Incorrect mapping count statistics generated for some ontologies #94

mdorf opened this issue Jul 12, 2019 · 3 comments
Assignees
@mdorf
Labels
bug

Comments

@mdorf
Copy link
Member

mdorf commented Jul 12, 2019 •
edited by graybeal

http://data.bioontology.org/mappings/statistics/ontologies/LUNGMAP-HUMAN

{
    "KTAO": 13,
    "FOODON": 1,
    "MSTDE": 1,
    "OGG": 1
}

This data is displayed in the UI:
https://bioportal.bioontology.org/ontologies/LUNGMAP-HUMAN/?p=mappings

Screen Shot 2021-03-10 at 2 09 46 PM

http://data.bioontology.org/mappings/statistics/ontologies/LUNGMAP-MOUSE

{
    "OGG": 2,
    "MSTDE": 2,
    "FOODON": 1,
    "KTAO": 15,
    "ODNAE": 1
}

This data is displayed in the UI:
https://bioportal.bioontology.org/ontologies/LUNGMAP-MOUSE/?p=mappings

Screen Shot 2021-03-10 at 2 10 45 PM

Both ontologies have thousands of mappings to many more ontologies than the output above indicates. This is evident by calling the mappings endpoints:
http://data.bioontology.org/ontologies/LUNGMAP-HUMAN/mappings
http://data.bioontology.org/ontologies/LUNGMAP-MOUSE/mappings
@mdorf mdorf added the bug label Jul 12, 2019
@mdorf mdorf self-assigned this Jul 12, 2019
@mdorf
Copy link
Member Author

mdorf commented Jul 12, 2019

The suspect code is def self.create_mapping_counts(logger), located here:
https://github.com/ncbo/ontologies_linked_data/blob/master/lib/ontologies_linked_data/mappings/mappings.rb#L589

mdorf added a commit that referenced this issue Mar 20, 2021
@mdorf
fixed #115, #94
182cb1a
@graybeal
Copy link

The number of mappings shown for these two endpoints as of today is 4127 and 5807.

The number of mappings between LUNGMAP-HUMAN and LUNGMAP-MOUSE is shown in API and UI as 226.

This is now resolved, likely due to the work completed recently on #115.

@mdorf
Copy link
Member Author

mdorf commented Apr 30, 2021 •
edited

resolved, deployed, tested

@mdorf mdorf closed this as completed Apr 30, 2021
galviset referenced this issue in EarthPortal/ontologies_linked_data Mar 14, 2024
@syphax-bouazzouni
Merge pull request #94 from ontoportal-lirmm/feature/support-multi-la…
50619e6 
…ngual-search

Feature: Support multilangual search
galviset referenced this issue in EarthPortal/ontologies_linked_data Mar 14, 2024
@syphax-bouazzouni @RaimiSol
Merge to master: Release 2.4.2 - Multilingual & Submission compressio…
aa5081d 
…n (#96)

* fix  json serializer nil exception (#79)

if hash was missing @context key the json serializer throwed a nil exception

* Merge pull request #87 from ontoportal-lirmm/fix/achived-submission-space-optimization

Fix: Archived submission space optimization

* Merge pull request #71 from ontoportal-lirmm/feature/support-multilingual-read-one-language-from-request-parameter

Feature: Support multilingual - Add read one language from request parameter tests

* Merge pull request #73 from ontoportal-lirmm/feature/add-request-language-to-context

Feature/add request language to context

* fix  json serializer nil exception (#79)

if hash was missing @context key the json serializer throwed a nil exception

* Merge pull request #83 from ontoportal-lirmm/feature/add-request-language-to-context

Feature: add request language to context follow up

* Merge pull request #93 from ontoportal-lirmm/support-multi-lang-part-02

Feature: Add request all languages unit test

* Merge pull request #94 from ontoportal-lirmm/feature/support-multi-langual-search

Feature: Support multilangual search

---------

Co-authored-by: Raimi Solorzano Niederhausen <44089477+RaimiSol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdorf mdorf

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graybeal @mdorf