Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated link to reset password uses insecure protocol #98

Closed
jvendetti opened this issue Dec 11, 2019 · 5 comments
Closed

Generated link to reset password uses insecure protocol #98

jvendetti opened this issue Dec 11, 2019 · 5 comments
Assignees

Comments

@jvendetti
Copy link
Member

Reported by an end user:

FYI, the link below is HTTP and not HTTPS...

admin@bioontology.org wrote on 12/4/19 6:34 PM:
Someone has requested a password reset for user xxx. If this was you, please click on the link below to reset your password. Otherwise, please ignore this email.

http://bioportal.bioontology.org/reset_password

We're hard-coding the HTTP protocol in the reset_password method.

@jvendetti jvendetti self-assigned this Dec 11, 2019
@andrew-nguyen
Copy link

It would also be helpful if http://bioportal.bioontology.org redirected automatically to https. Thanks!

@andrew-nguyen
Copy link

Another related issue is the token never seems to expire (either after a certain amount of time or after being used once). I just clicked on the link that was generated over a week ago and was able to arbitrarily reset my password again.

@jvendetti
Copy link
Member Author

Another related issue is the token never seems to expire (either after a certain amount of time or after being used once).

I entered a separate issue for this, as the code that generates the tokens lives in a different repository. See ncbo/ontologies_api#60.

@jvendetti
Copy link
Member Author

It would also be helpful if http://bioportal.bioontology.org redirected automatically to https

Yes, we agree. See relevant issues:

ncbo/bioportal-project#83
ncbo/biomixer#2

@jvendetti
Copy link
Member Author

Fixed with this commit: 78fa10a

galviset referenced this issue in EarthPortal/ontologies_linked_data Mar 14, 2024
…el-features

Fix: Disable attributes on update callbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants