Fix issue #194 :: check for ArnLike conditions

nccgroup · Nov 16, 2017 · 2123375 · 2123375
1 parent 8756a21
commit 2123375
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/AWSScout2/rules/data/findings/sns-topic-world-policy.json b/AWSScout2/rules/data/findings/sns-topic-world-policy.json
@@ -14,9 +14,21 @@
             [ "sns.regions.id.topics.id.Policy.Statement.id.", "withoutKey", "Condition" ],
             [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.", "withoutKey", "StringEquals" ],
             [ "and",
-                [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.StringEquals.", "withoutKey", "sns:SourceArn" ],
+                [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.StringEquals.", "withoutKey", "aws:SourceArn" ],
+                [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.StringEquals.", "withoutKey", "aws:SourceOwner" ],
+                [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.StringEquals.", "withoutKey", "AWS:SourceArn" ],
                 [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.StringEquals.", "withoutKey", "AWS:SourceOwner" ]
             ]
+        ],
+        [ "or",
+            [ "sns.regions.id.topics.id.Policy.Statement.id.", "withoutKey", "Condition" ],
+            [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.", "withoutKey", "ArnLike" ],
+            [ "and",
+                [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.ArnLike.", "withoutKey", "aws:SourceArn" ],
+                [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.ArnLike.", "withoutKey", "aws:SourceOwner" ],
+                [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.ArnLike.", "withoutKey", "AWS:SourceArn" ],
+                [ "sns.regions.id.topics.id.Policy.Statement.id.Condition.ArnLike.", "withoutKey", "AWS:SourceOwner" ]
+            ]
         ]
     ]
 }