Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

check_for_duplicate(rds_info) issue #26

Closed
leo100 opened this issue Aug 5, 2015 · 6 comments
Closed

check_for_duplicate(rds_info) issue #26

leo100 opened this issue Aug 5, 2015 · 6 comments

Comments

@leo100
Copy link

leo100 commented Aug 5, 2015

Hello,

I'm getting errors when "Analyzing RDS data..."
Analyzing RDS data...
'datetime.datetime' object has no attribute 'read'
Traceback (most recent call last):
File "Scout2.py", line 195, in
sys.exit(main(args))
File "Scout2.py", line 121, in main
method(aws_config['services'][service], aws_config['account_id'], args.force_write)
File "/home/username/scout/Scout2/AWSScout2/utils_rds.py", line 22, in analyze_rds_config
check_for_duplicate(rds_info)
File "/home/username/scout/Scout2/AWSScout2/utils_rds.py", line 26, in check_for_duplicate
if 'short-backup-retention-period' in rds_info['violations']:
KeyError: 'violations'

Commenting check_for_duplicate(rds_info) in /home/username/scout/Scout2/AWSScout2/utils_rds.py does the trick but needs to be fixed.

Thanks you.

l01cd3v added a commit that referenced this issue Aug 5, 2015
@l01cd3v
Copy link
Contributor

l01cd3v commented Aug 5, 2015

This should be fixed now. Thanks !

@leo100
Copy link
Author

leo100 commented Aug 5, 2015

Awesome l01cd3v!
It is fixed ;)
Had to upgrade opinel though.

Just a quick question (as someone who's not a python expert...at all) - I'm after specifying a list of Groups as an input and then spewing a list of users belonging to those specific groups, with "Lack of MFA" (possibly via cron so I could send this list to appropriate team).
Is it possible? How do I do that?

Thanks you!

@l01cd3v
Copy link
Contributor

l01cd3v commented Aug 7, 2015

Hey Leo100, I'll close the issue since it's fixed.

Regarding your other request, I have enhanced version of "ListItem.py" that might be used for that, but I'd have to tweak it to support that request and clean the code before sharing.

@l01cd3v l01cd3v closed this as completed Aug 7, 2015
@leo100
Copy link
Author

leo100 commented Aug 7, 2015

Hello l01cd3v,

Yep, thanks for that.
Do you have any ETA on "ListItem.py"?
I'd be happy to test it....
How are you going to release it?
Do you have a JIRA or something to follow these requests?

Thanks!!!!

Leon Kolchinsky

On 7 August 2015 at 10:04, l01cd3v notifications@github.com wrote:

Hey Leo100, I'll close the issue since it's fixed.

Regarding your other request, I have enhanced version of "ListItem.py"
that might be used for that, but I'd have to tweak it to support that
request and clean the code before sharing.


Reply to this email directly or view it on GitHub
#26 (comment).

@l01cd3v l01cd3v mentioned this issue Aug 7, 2015
@l01cd3v
Copy link
Contributor

l01cd3v commented Aug 7, 2015

Created issue #27 to follow up on this. Feel free to subscribe to it.

I don't have an ETA on that yet, but I'll try to get it out ASAP.

@craSH
Copy link

craSH commented Nov 24, 2015

Hello,

I've just encountered this same issue with the latest head of the Scout2 code as of this morning. I was running against an account with fairly limited access, so it didn't have permission to quite a few actions, and as such I don't think the dictionary key rds_info['violations'] was ever created. The exception is the same as the original defect posted here, though now the offending line is line number 23 (content is the same, though).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants