New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring - Leverage boto3 for Authentication #215
Refactoring - Leverage boto3 for Authentication #215
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #215 +/- ##
===========================================
+ Coverage 29.95% 30.47% +0.51%
===========================================
Files 74 73 -1
Lines 5428 5067 -361
===========================================
- Hits 1626 1544 -82
+ Misses 3802 3523 -279
Continue to review full report at Codecov.
|
6621ec7
to
b3f3650
Compare
b3f3650
to
5371c19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
Made some changes & tested for:
README should be updated. It would also be worthwhile to link to https://aws.amazon.com/premiumsupport/knowledge-center/authenticate-mfa-cli/ for MFA configuration. |
Updated README following PR #215
PR in response to this issue.
Currently WIP till further feedback/approval.
What has been done :
credentials.py
which came from Opinel and by the same move we also got rid ofRequests
Session()
instead.aws/credentials
file, which is the standard/documented AWS method)