Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README following PR #215 #223

Merged
merged 3 commits into from Mar 6, 2019
Merged

Conversation

vifor2
Copy link
Contributor

@vifor2 vifor2 commented Mar 5, 2019

Update README.md following this PR.

  • Removed the mentions that Python 2.7 & 3.4 are supported since we will be getting rid of them for the next release.
  • Now telling the user to configure MFA themselves following @j4v's changes.
  • No longer telling the user they can identify with a CSV file since it has been removed.

@vifor2 vifor2 added the component-provider-aws Affects AWS provider label Mar 5, 2019
@vifor2 vifor2 added this to the Iteration #4 milestone Mar 5, 2019
@vifor2 vifor2 self-assigned this Mar 5, 2019
@vifor2 vifor2 added this to In progress in Scout Suite via automation Mar 5, 2019
Copy link
Contributor

@zer0x64 zer0x64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to deal with the "Python2 will be deprecated" in the current release, but other than that it's good!

README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #223 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #223   +/-   ##
========================================
  Coverage    30.47%   30.47%           
========================================
  Files           73       73           
  Lines         5067     5067           
========================================
  Hits          1544     1544           
  Misses        3523     3523

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0441a20...452aebf. Read the comment docs.

@x4v13r64
Copy link
Collaborator

x4v13r64 commented Mar 6, 2019

Not sure how to deal with the "Python2 will be deprecated" in the current release, but other than that it's good!

I'd say update the readme with a warning and make it clear in the release notes. All of the refactoring will likely be released under a 5.0.0 number, so we can make a big deal of all the changes.

@Aboisier Aboisier merged commit ad1410d into develop Mar 6, 2019
Scout Suite automation moved this from In progress to Done Mar 6, 2019
@vifor2 vifor2 deleted the cleanup/readme-mfa-update branch March 6, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-provider-aws Affects AWS provider
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants