Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/sqs #262

Merged
merged 9 commits into from Mar 25, 2019
Merged

Refactoring/aws/sqs #262

merged 9 commits into from Mar 25, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 18, 2019

This PR aims to migrate AWS SQS service to the new architecture, as part of #183.

@misg misg self-assigned this Mar 18, 2019
@misg misg added this to In progress in Scout Suite via automation Mar 18, 2019
@misg misg added this to the Iteration #4 milestone Mar 18, 2019
@Aboisier Aboisier mentioned this pull request Mar 18, 2019
53 tasks
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I didn't approve right away because think it's really important to separate the concerns. Also the build is broken what's up with that.

@Aboisier Aboisier mentioned this pull request Mar 18, 2019
@misg
Copy link
Contributor Author

misg commented Mar 18, 2019

Looks good! I didn't approve right away because think it's really important to separate the concerns. Also the build is broken what's up with that.

image
😭

@codecov-io
Copy link

Codecov Report

Merging #262 into refactoring/resource-configs will increase coverage by 0.01%.
The diff coverage is 38%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #262      +/-   ##
================================================================
+ Coverage                         31.76%   31.78%   +0.01%     
================================================================
  Files                               146      147       +1     
  Lines                              5805     5827      +22     
================================================================
+ Hits                               1844     1852       +8     
- Misses                             3961     3975      +14
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/sqs.py 33.33% <33.33%> (ø)
ScoutSuite/providers/aws/resources/sqs/service.py 37.5% <37.5%> (ø)
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️
ScoutSuite/providers/aws/facade/facade.py 45.58% <66.66%> (+0.97%) ⬆️
ScoutSuite/output/js.py 25% <0%> (-0.36%) ⬇️
ScoutSuite/providers/aws/services/sqs.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93bcde...8e64e8e. Read the comment docs.

@misg misg merged commit 0935e1f into refactoring/resource-configs Mar 25, 2019
Scout Suite automation moved this from In progress to Done Mar 25, 2019
@misg misg deleted the refactoring/aws/sqs branch March 25, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants