Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/629 #667

Merged
merged 2 commits into from Mar 12, 2020
Merged

Issue/629 #667

merged 2 commits into from Mar 12, 2020

Conversation

x4v13r64
Copy link
Collaborator

@x4v13r64 x4v13r64 commented Mar 12, 2020

Description

Fixes #629.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@x4v13r64 x4v13r64 changed the base branch from master to develop March 12, 2020 16:16
@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #667 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #667   +/-   ##
========================================
  Coverage    65.21%   65.21%           
========================================
  Files           22       22           
  Lines         1515     1515           
========================================
  Hits           988      988           
  Misses         527      527           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f6316...b601089. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Mar 12, 2020

This pull request introduces 1 alert when merging b601089 into 6cadac7 - view on LGTM.com

new alerts:

  • 1 for Unused import

@x4v13r64 x4v13r64 merged commit 368bb18 into develop Mar 12, 2020
@x4v13r64 x4v13r64 deleted the issue/629 branch March 12, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws ERROR provider.py L315: put_cidr_name() missing 1 required positional argument: 'callback_args'
2 participants