Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DynamoDB #759

Merged
merged 17 commits into from Jul 19, 2020
Merged

Add support for DynamoDB #759

merged 17 commits into from Jul 19, 2020

Conversation

klauern
Copy link
Contributor

@klauern klauern commented May 30, 2020

Description

Adds initial support for DynamoDB to the Open Source project.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@lgtm-com
Copy link

lgtm-com bot commented May 30, 2020

This pull request introduces 1 alert when merging 830ac86 into eac628c - view on LGTM.com

new alerts:

  • 1 for Unused import

@x4v13r64
Copy link
Collaborator

Thanks @klauern will review ASAP.

Build is failing for python3.5 but looks like a minor issue.

@x4v13r64 x4v13r64 added component-provider-aws Affects AWS provider enhancement New feature or request labels May 30, 2020
@klauern
Copy link
Contributor Author

klauern commented May 30, 2020

No rush on this. I marked it as a "draft" so I could continue pushing some changes. I haven't gotten to any of the UI changes, so I have a few things that I am going to keep working on.

My list of things that I want to continue:

  • smooth out the snake_case function
  • add UI component (if missing)
  • add a rule to check if a table has SSE enabled on it

@klauern
Copy link
Contributor Author

klauern commented May 30, 2020

For the Python 3.5 issue, it looks like it's related to my use of f-strings. Is 3.5 a requirement? Could we bump to 3.6+?

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #759 into develop will increase coverage by 0.34%.
The diff coverage is 96.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #759      +/-   ##
===========================================
+ Coverage    66.53%   66.88%   +0.34%     
===========================================
  Files           22       22              
  Lines         1536     1552      +16     
===========================================
+ Hits          1022     1038      +16     
  Misses         514      514              
Impacted Files Coverage Δ
ScoutSuite/providers/aws/utils.py 94.33% <96.66%> (+2.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac628c...c69f2d0. Read the comment docs.

@klauern klauern marked this pull request as ready for review May 31, 2020 02:01
@lgtm-com
Copy link

lgtm-com bot commented May 31, 2020

This pull request introduces 1 alert when merging 3c9af65 into eac628c - view on LGTM.com

new alerts:

  • 1 for Unused import

@x4v13r64
Copy link
Collaborator

No rush on this. I marked it as a "draft" so I could continue pushing some changes.

Cool, please request the review when ready.

For the Python 3.5 issue, it looks like it's related to my use of f-strings. Is 3.5 a requirement? Could we bump to 3.6+?

EOL for 3.5 is 2020-09-13, I guess there's no harm in deprecating support.

@x4v13r64 x4v13r64 added this to the 5.10 milestone May 31, 2020
@klauern
Copy link
Contributor Author

klauern commented May 31, 2020

I'm not able to reproduce the error in Travis. I did change off of f-strings, but it failed on test-resources.py. I ran the same test on a 3.5 version, and it passes for me:

image

@klauern
Copy link
Contributor Author

klauern commented Jun 4, 2020

I fixed the tests. I forgot that I added another condition and it fell off my radar. Apologies.

# Conflicts:
#	ScoutSuite/providers/aws/services.py
#	ScoutSuite/providers/aws/utils.py
#	tests/test_utils.py
@x4v13r64 x4v13r64 merged commit 27171b0 into develop Jul 19, 2020
@x4v13r64 x4v13r64 deleted the nklauer/dynamodb branch July 19, 2020 09:31
@x4v13r64
Copy link
Collaborator

@klauern I've merged your PR with our proprietary implementation. All that should be missing now is the SSE check which you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-provider-aws Affects AWS provider enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants