New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DynamoDB #759
Conversation
This pull request introduces 1 alert when merging 830ac86 into eac628c - view on LGTM.com new alerts:
|
Thanks @klauern will review ASAP. Build is failing for python3.5 but looks like a minor issue. |
No rush on this. I marked it as a "draft" so I could continue pushing some changes. I haven't gotten to any of the UI changes, so I have a few things that I am going to keep working on. My list of things that I want to continue:
|
For the Python 3.5 issue, it looks like it's related to my use of f-strings. Is 3.5 a requirement? Could we bump to 3.6+? |
Codecov Report
@@ Coverage Diff @@
## develop #759 +/- ##
===========================================
+ Coverage 66.53% 66.88% +0.34%
===========================================
Files 22 22
Lines 1536 1552 +16
===========================================
+ Hits 1022 1038 +16
Misses 514 514
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 3c9af65 into eac628c - view on LGTM.com new alerts:
|
Cool, please request the review when ready.
EOL for 3.5 is 2020-09-13, I guess there's no harm in deprecating support. |
I fixed the tests. I forgot that I added another condition and it fell off my radar. Apologies. |
# Conflicts: # ScoutSuite/providers/aws/services.py # ScoutSuite/providers/aws/utils.py # tests/test_utils.py
@klauern I've merged your PR with our proprietary implementation. All that should be missing now is the SSE check which you mentioned. |
Description
Adds initial support for DynamoDB to the Open Source project.
Type of change
Select the relevant option(s):
Checklist: