Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty env or missing/broken printenv() #37

Closed
jynik opened this issue Sep 26, 2020 · 1 comment
Closed

Allow empty env or missing/broken printenv() #37

jynik opened this issue Sep 26, 2020 · 1 comment
Assignees
@jynik
Labels
bug Unexpected failure or code-related issue staged Staged in 'next' branch for future release
Milestone
0.2.0

Comments

@jynik
Copy link
Collaborator

jynik commented Sep 26, 2020

Currently, if we encounter an entirely empty environment or the printenv command doesn't work, we error our.

Opening a issue to track the fix for this; ideally we should just emit an error message but still try to finish initialization.
@jynik jynik added the bug Unexpected failure or code-related issue label Sep 26, 2020
@jynik jynik self-assigned this Sep 26, 2020
jynik added a commit to jynik/depthcharge that referenced this issue Sep 26, 2020
@jynik
python: Log error instead of "crash" upon failure to find environment
cdcb3a5 
Log an error, rather than crash with an exception, if we cannot find
any environment variables via `printenv`.  The intent here is to be
more resilient to bizarre platforms or those that are specifically
configured to not be so generous to us.

Fixes nccgroup#37.
@jynik jynik mentioned this issue Sep 26, 2020
Merged
jynik added a commit that referenced this issue Sep 26, 2020
@jynik
python: Log error instead of "crash" upon failure to find environment
81a97ca 
Log an error, rather than crash with an exception, if we cannot find
any environment variables via `printenv`.  The intent here is to be
more resilient to bizarre platforms or those that are specifically
configured to not be so generous to us.

Fixes #37.
@jynik
Copy link
Collaborator Author

jynik commented Sep 26, 2020

Staged in next @ 81a97ca

@jynik jynik added the staged Staged in 'next' branch for future release label Sep 26, 2020
@jynik jynik mentioned this issue Oct 2, 2020
Merged
@jynik jynik added this to the 0.2.0 milestone Oct 19, 2020
@jynik jynik closed this as completed in 91be987 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jynik jynik

Labels
bug Unexpected failure or code-related issue staged Staged in 'next' branch for future release
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@jynik