python: Log error instead of "crash" upon failure to find environment #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log an error, rather than crash with an exception, if we cannot find any environment variables via `printenv`. The intent here is to be more resilient to bizarre platforms or those that are specifically configured to not be so generous to us. Fixes nccgroup#37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log an error, rather than crash with an exception, if we cannot find
any environment variables via
printenv. The intent here is to bemore resilient to bizarre platforms or those that are specifically
configured to not be so generous to us.
Fixes #37.