memory: More lenient hex dump output matching #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following was observed on a device running (a fork of) U-Boot 2012.10
when a small (word-wise) memory read was performed when validating an
applied MemoryPatch:
depthcharge.operation.OperationFailed:
Failed to parse line: bff64d92: f7ff ffd5 ....
This failure arises from our regular expression expecting 16 characters
in the ASCII section of the hex dump output, which clearly is not the
case here. (It seems newer versions pad up to a fixed line length.)
We now look for 1 to 16 characters. I don't recall U-Boot ever
outputting an address followed by an empty line, hence not {0, 16}.
Fixes nccgroup#91
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following was observed on a device running (a fork of) U-Boot 2012.10
when a small (word-wise) memory read was performed when validating an
applied MemoryPatch:
This failure arises from our regular expression expecting 16 characters
in the ASCII section of the hex dump output, which clearly is not the
case here. (It seems newer versions pad up to a fixed line length.)
We now look for 1 to 16 characters. I don't recall U-Boot ever
outputting an address followed by an empty line, hence not {0, 16}.
Fixes #91