Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/juniper various improvements (issue #236 plus more): #243

Merged

Conversation

attila123
Copy link

  • Old, python 2 style print statements replaced with logging.info() (logging configured to show date, python file name and line number),
  • Using bigger timeout values for manager.connect(), needed by e.g. Juniper SRX 300 (which I could test with) for some operations,
  • More meaningful, less confusing/misleading/sloppy variable names,
  • get-configuration-jnpr.py: fix: the result of get_configuration() used a bit different data structure,
  • get-xnm-information.py: XML (NCElement) to str conversion fix for python 3,
  • Some/most PEP 8 code formatting issues were fixed (what I noticed in PyCharm),
  • Unnecessary user input (raw_input()) removed from the examples where it was present, easier to run them this way (especially multiple times),
  • Note: some examples may still be broken, did not have time to debug all of them.

- Old, python 2 style print statements replaced with logging.info() (logging configured to show date, python file name and line number),
- Using bigger timeout values for manager.connect(), needed by e.g. Juniper SRX 300 (which I could test with) for some operations,
- More meaningful, less confusing/misleading/sloppy variable names,
- get-configuration-jnpr.py: fix: the result of get_configuration() used a bit different data structure,
- get-xnm-information.py: XML (NCElement) to str conversion fix for python 3,
- Some/most PEP 8 code formatting issues were fixed (what I noticed in PyCharm),
- Unnecessary user input (raw_input()) removed from the examples where it was present, easier to run them this way (especially multiple times),
- Note: some examples may still be broken, did not have time to debug all of them.
@attila123 attila123 changed the title examples/juniper various improvements: examples/juniper various improvements (issue #236 plus more): Jun 19, 2018
@coveralls
Copy link

coveralls commented Jun 19, 2018

Coverage Status

Coverage decreased (-0.6%) to 68.41% when pulling a7ac610 on attila123:examples_juniper_various_improvements into 23df9a7 on ncclient:master.

@einarnn einarnn merged commit b845d1e into ncclient:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants