Simplify NodeStatusReport, avoid allocation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
approved these changes
Feb 6, 2020
ncharles
merged commit c40c8f2
into
ncharles:bug_16661/inneficient_computation_of_rulestatusreports_and_nodestatusreports
ncharles
added a commit
that referenced
this pull request
Feb 7, 2020
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
ncharles
added a commit
that referenced
this pull request
Feb 7, 2020
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
ncharles
added a commit
that referenced
this pull request
Mar 13, 2020
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
ncharles
added a commit
that referenced
this pull request
Mar 13, 2020
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
ncharles
added a commit
that referenced
this pull request
Mar 13, 2020
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
ncharles
added a commit
that referenced
this pull request
Mar 13, 2020
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR directly use a
Set[RuleNodeStatusReport]inNodeStatusReport. It seems to change nothing, and it allows to avoid a lots ofAggregatedReportsalloc.