Refactor worker, add hapi/handlebars #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some jank involved with making Handlebars run on a worker, and with loading precompiled templates. I'll document this after I finish refactoring. The build step is now broken out into a Node script, where it's easier to run many commands. Given it's still Node though, it's fairly cross-platform at least.
Some details are better obtained client-side, rather than by the worker. Namely, the origin the worker is being served from. It's unreliable to fetch this from headers or request data, since the value doesn't match to the actual origin when using wrangler dev (instead of localhost, it's the deployed URL).
Once again needs some jank to make it work, will document later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hapi/calland@hapi/boomfor better routing and error handlingUnfortunately there's still a bit of jank in getting handlebars and hapi libraries to run on Cloudflare Workers. These are mostly products of Cloudflare's custom runtime.
evalis disallowedglobal/window/Buffer) need to be mocked with dummy values, otherwiseReferenceErrors will crop up when the worker is run