Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to upload some artifacts #12

Closed
OpportunityLiu opened this issue Feb 29, 2020 · 5 comments
Closed

Failed to upload some artifacts #12

OpportunityLiu opened this issue Feb 29, 2020 · 5 comments
Assignees

Comments

@OpportunityLiu
Copy link

Artifacts randomly failed to upload these days. Should an option of retry be added?

图片
图片

@ncipollo
Copy link
Owner

ncipollo commented Mar 2, 2020

Hmm, I'm not sure how a retry would work, but I could look into allowing the action to replace existing artifacts if they already exist.

ncipollo pushed a commit that referenced this issue Mar 3, 2020
ncipollo pushed a commit that referenced this issue Mar 3, 2020
ncipollo pushed a commit that referenced this issue Mar 3, 2020
@ncipollo
Copy link
Owner

ncipollo commented Mar 3, 2020

I updated the action so it will replace existing artifacts if you run it again (with allowUpdates set to true). Not sure this will 100% fix your problem since I'm not sure why github randomly fails for some of the artifacts... but you can at least re-run your workflow now 🙃 .

Feel free to re-open or create a new issue if this continues to cause issues. I could have it retry once or twice if it fails but I suspect that if there are intermittent issues with the github api it would still fail.

@OpportunityLiu
Copy link
Author

If run the action twice is regarded as a solotion, the original version (skip existing artifacts) DO solve the problem, except that you got a warning for every artifact succeeded in the first upload.

If you replace existing artifacts, the first run is meaningless since you delete and re-upload them at the second run.

@OpportunityLiu
Copy link
Author

I've added some debug output and found this:

图片
I think it's ok to retry when we got a 5xx response

@ncipollo
Copy link
Owner

ncipollo commented Mar 5, 2020

Thanks for the fix @OpportunityLiu !

@ncipollo ncipollo closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants