fetchOSD series names should be checked within extended components

[dylanbeaudette]

When asking for extended summaries there is no check to ensure that the set of series names present in the summaries match those in the SPC. This can occur in likely 2 scenarios:

1. query for data outside of CONUS: climate summaries are empty data.frames
2. query for data within CONUS, OSD morphology missing due to funky formatting or typos in the OSD

Case 2 is a problem for analysis expecting identical vectors of series names in both SPC and climate summaries. Examples:

• Breadsprings: OSD parsed OK (2020-03-20), OSD hz data missing (2019-11-18)
• Hagerwest: OSD parsed OK (2020-03-20), OSD hz data missing (2019-11-18)
• Tintero: OSD parsed OK (2020-03-20), OSD hz data missing (2019-11-18)

These series are marked as inactive, thus removed before parsing. fetchOSD should perform some level of checking / reporting / filtering (?) when the extended data aren't consistent with the SPC.

The following will fail if only Breadsprings is specified, but returns an internally inconsistent set of objects if other series are included.

library(soilDB)

# report no data as expected
soils <- c('xxx')
x <- fetchOSD(soils, extended = TRUE)

# report no data as expected 
soils <- c('Breadsprings')
x <- fetchOSD(soils, extended = TRUE)

# works
soils <- c('amador')
x <- fetchOSD(soils, extended = TRUE)

# inconsistent SPC + extended data
soils <- c('cecil', 'Breadsprings')
x <- fetchOSD(soils, extended = TRUE)

[dylanbeaudette]

After some thought, fetchOSD should not fail in these cases but should issue a warning with a pointer to the manual page.