Fixes and new tools for working with uncode, factors, and NASIS metadata #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownag
force-pushed
the
factorsETC
branch
2 times, most recently
from
b0d1852
to
f861a1f
Compare
brownag
changed the title
…from factor - uncode: Use `NASISDomainsAsFactor()` to check package option
|
Nice. Thanks for addressing these. |
|
Tested and confirmed to fix several instances where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #241
get_NASIS_metadata()--pulls some more of the new logic fromuncode()related to caching of results, and adds to result from pre-existing internal function.get_NASIS_metadata()get_NASIS_column_metadata()for quickly subsetting the NASIS metadata table based on various constraints. Provides "easy" access to the metadata for use in functions that need to perform specific operations on domains/values/labels/names/sequences etc.RE: #242
Addresses column names used in
get_cosoilmoist_from_SDA()result for soil moisture state and top/bottom depths (L, RV, H);"status"->"soimoiststat","dep[tb]_[lrh]"->"soimoistdep[tb]_[lrh]"RE: Data loss when using uncode() #253
Fixes problems with
uncode()and.cosoilmoist_prep()(and other SDA functions using similar factor logic) reported by @monikasheaAlso adds some simple tests for
uncode()andcode()with and withoutNASISDomainsAsFactor(TRUE)