fix: ncyBreadcrumbIgnore flag

[kazinov]

Provides the way to ignore some views when rendering breadcrumbs. To achieve this the property ncyBreadcrumbIgnore should be set to true on the view controller scope:

function ViewController($scope) {
       $scope.ncyBreadcrumbIgnore = true;
}

This allows to deal with multiple views related to the same state.
Closes the issue #42 and possibly the issue #62
This plunker demonstrates a common problem with footer view which could be solved with this fix.

[ncuillery]

Hi, many thanks for the PR.

The idea of attach a configuration param to the scope sounds a bit dirty to me (I prefer centralize the breadcrumb configuration in the same place) but I recognize it's a simple and effective way to solve two major issues.

It LGTM. I'll make a detailled review of this.

[ncuillery]

I think the problem this PR solve is more related to multiple views than abstract view.

Tell me if I'm wrong but it doesn't matter if the state is abstract or not (I remove the abstract: true line in the plunker and the problem still occurs).

I suggest naming the conf 'ncy-multiple-interpolation-conf'here (and update the describe's name below).

[ncuillery]

Review done 👍

Please can you amend the commit and changing the title to feat: add the scope-based ncyBreadcrumbIgnore flag and add Closes #42 #62 at the end of the commit message after a blank line.

Thank you for all of this 😄

[kazinov]

will do today

[kazinov]

Hi, @ncuillery
I changed the commit name and made some refactoring you asked for.

If you will update the documentation please consider mentioning the special case with inherited scopes.
Example here

[ncuillery]

Landed 👍 the release will arrive soon.

I confirm it solves the #62 too !