-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ncyBreadcrumbIgnore flag #99
Conversation
Hi, many thanks for the PR. The idea of attach a configuration param to the scope sounds a bit dirty to me (I prefer centralize the breadcrumb configuration in the same place) but I recognize it's a simple and effective way to solve two major issues. It LGTM. I'll make a detailled review of this. |
/** | ||
* Module with abstract state with footer view | ||
*/ | ||
angular.module('ncy-abstract-interpolation-conf', []).config(function($stateProvider) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem this PR solve is more related to multiple views than abstract view.
Tell me if I'm wrong but it doesn't matter if the state is abstract or not (I remove the abstract: true
line in the plunker and the problem still occurs).
I suggest naming the conf 'ncy-multiple-interpolation-conf'
here (and update the describe's name below).
Review done 👍 Please can you amend the commit and changing the title to Thank you for all of this 😄 |
will do today |
Provide the way to ignore some views when rendering breadcrumbs. To achieve this the property ncyBreadcrumbIgnore should be set to true on the view controller scope. Closes ncuillery#42 ncuillery#62
Rename ncy-abstract-interpolation-conf to ncy-multiple-interpolation-conf. Make state not abstract. It doesn't matter is there abstract states. The problem is multiple views.
Hi, @ncuillery If you will update the documentation please consider mentioning the special case with inherited scopes. |
feat: add the scope-based ncyBreadcrumbIgnore flag
Landed 👍 the release will arrive soon. I confirm it solves the #62 too ! |
Provides the way to ignore some views when rendering breadcrumbs. To achieve this the property
ncyBreadcrumbIgnore
should be set to true on the view controller scope:This allows to deal with multiple views related to the same state.
Closes the issue #42 and possibly the issue #62
This plunker demonstrates a common problem with footer view which could be solved with this fix.