Q: Thread-safe Connection?

[simonklee]

As far as I can see a Connection is not thread safe. Is that a correct assertion?

[ncw]

The basic operations of the Connection are thread safe as long as your token doesn't expire.

When the token expires a re-authentication is performed. If this was performed by multiple threads it would merely be inefficient rather than incorrect I think.

I've certainly used the connection from multiple threads myself without a problem.

To be absolutely certain it could do with a bit of locking - Call should take a read lock, which it should upgrade to a write lock on re-authentication. It could also do with some tests in swift_internal_test.go which I never quite completed!

[simonklee]

Yes, access to shared variables on Connection should be properly protected. Thanks for answering the question.