Update #1
Merged
Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LoadError` action was mapped to the `Load<%= className %>` action type rather than `<%= className %>LoadError`.
This adds the support to generate an application with the `inline-template` flag activated. Two new utils added: `getDecoratorPropertyValueNode` & `replaceNodeValue`. Add some tests ensure to test the two ways of generating template, using `templateUrls` and `inlineTemplate`. Tests are unising the flag `inlineTemplate`. close #519
implicitDependencies between files and projects are already able to be specified in nx.json, so this adds the ability to specify implicitDependencies between one project and (multiple) others. By extension, this also enables a more flexible e2e suite naming convention than was previously supported. Closes #665
When injecting a store reference, the store state should be an inline type
based on the feature key that was registered with `StoreModule.forFeature(...)`.
Consider the facade generated for feature 'cars':
```ts
StoreModule.forFeature('cars', carsReducer, { initialState: carsInitialState })
```
```ts
@Injectable()
export class CarsFacade {
constructor( private store: Store<{cars: CarsState}> ) { }
}
```
Currently the `dry-run` command speed is on an average of: * `ng g app app_name --dry-run`: 7099.051ms to 7207.579ms; * `ng g lib lib_name --dry-run`: 4015.622ms to 3881.893ms; This is due to too many files in the tree. While performing the transformation required by the schematic, the tree inclues files in the _node_modules, .git, .idea, .vscode_ folders. These files are not needed and impact the performance of the commandline. This add a filter function on the tree, before anything is moved. With that filter function the average speed is: * `ng g app app_name --dry-run`: 1420.826ms to 1435.487ms; * `ng g lib lib_name --dry-run`: 1382.279ms to 1413.042ms; close #706
Update the lib's `package.json` name with the right prefix, when generating a lib with the `publishable` option set to 'true'. close #677
This adds the ability to automate the format of the commit by prompting the information needed in sequence. It is then easier to follow the standard format of the repository. A commit check has been added to the CI too.
This adds a hook to the git command to run prettier on the staged files, before committing. Prettier has now more broad and general rules with excluded folder and more files to correct.
When running the affected command with the `--parallel` option, `npm-run-all` is used to achieve the parallel execution of the desired tasks. Because of the use of `npm-run-all`, the `ng` command should be visible and declared as script command in the `package.json` of your project. This adds a verification before runing the command with the `--parallel` option to make sure the `package.json` has the `ng: "ng"` command in the `scripts` section. close #700
The format command now splits all the array containing all the urls and patterns given, in smaller chunks arrays, executing the command on each chunks. This prevent to have too long argument on the command for the terminal, which can lead to error on specific OS. The chaining of command is transparent for the user. close #511
ndcunningham
pushed a commit
that referenced
this pull request
Aug 15, 2023
ndcunningham
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.