Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to suggest two PRs for the variations filter and had to set up a local dev environment to make changes. Therefore, I thought I might as suggest it as an PR for you and other contributors.
For convenience, I've added an easier local development environment using @wordpress/env.
This allows for simpler setup of local dev environment and also ensures all contributors have the same local dev setup. More information about that package here: https://developer.wordpress.org/block-editor/reference-guides/packages/packages-env/
I've also added npm scripts to make it easier to use the wp-env version installed in the package. The naming of these scripts is arbitrary.
I've also fixed the node/npm version used in this plugin. I guessed it was initially v14 (because all versions above try to migrate the package-lock.json). I then updated it to v16 to be on par with Gutenberg. This makes it easier for developers to use the correct node/npm version (using nvm).
Testing:
nvm use
if you have multiple node versions installednpm install
npm run dev:start
to startup local dev environmentNothing about the plugin functionality or the build process changes/should change.