Try/variation icons editor

[gaambo]

Tries solution no 3 for #21.
The icon and label for social sharing link variations (=services) will be get from all registered block variations (the data store) and not from the hardcoded variations of the plugin.

Testing instructions:

1. Register a custom block variation for the outermost/social-sharing-link block in JavaScript (editor):

import { link as linkIcon } from "@wordpress/icons";
registerBlockVariation("outermost/social-sharing-link", {
    name: "link",
    isDefault: true,
    title: __("Link"),
    icon: linkIcon,
    attributes: {
      service: "link",
    },
    isActive: (blockAttributes, variationAttributes) => blockAttributes.service === "link",
  });

2. Add a social sharing block in the editor and add this variation as a child.
3. The block displays the correct icon and label (renderd in the button!)

Important: Does only work with icons set to SVG/react components. If you pass a string (like the name of a Dashicon) the string directly will be rendered.

TODO:

• Maybe check that icon is a component and not a string
• Map Twitter to X

Important 2
This is based on top of the add/local-dev-environment branch of my fork. I can cherry pick only the one commmit required for this issue (e074114) or (if PR #20 gets merged) rebase this branch on the upstream main.

[philcable]

Hi @gaambo, thank you very much for diving into this! It was completely unexpected and much appreciated.

I left one thought on the approach - feel free to take it or leave it 🙂!

[ndiego]

Closing in favor of #23. Thanks so much for outlining the solution here!