Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Input data metrics in log files in the batch mode #208

Closed
DenisGoryunov opened this issue May 19, 2023 · 16 comments
Closed

Incorrect Input data metrics in log files in the batch mode #208

DenisGoryunov opened this issue May 19, 2023 · 16 comments

Comments

@DenisGoryunov
Copy link

DenisGoryunov commented May 19, 2023

Hello Nicolas,

I ran 57 samples as one batch with NOVOPlasty Version 4.3.1 and found very strange Input data metrics in log files for the majority of the samples. E.g. for the sample №55 i got:

**-----------------------------------------Input data metrics-----------------------------------------

Total reads : 4456742
Aligned reads : 6700394
Assembled reads : 5452210
Organelle genome % : 150.34 %
Average organelle coverage : 7471**

Then i reran NOVOplasty, but left only one sample №55 in the batch file. Now Input data metrics of the sample looks much more realistic:

**-----------------------------------------Input data metrics-----------------------------------------

Total reads : 4456742
Aligned reads : 365934
Assembled reads : 294278
Organelle genome % : 8.21 %
Average organelle coverage : 408**

How can i get the correct Input data metrics for the large batch with 57 samples, as i need this statistics for the paper preparation?

Many thanks,
Denis

@ndierckx
Copy link
Owner

ndierckx commented Jun 8, 2023

Hi, I think I never adapted the metrics for the batch function, so I guess I need to change it in the code in a way it outputs it per sample. But you will need to rerun it if you need those statistics, is it urgent?

@DenisGoryunov
Copy link
Author

DenisGoryunov commented Jun 8, 2023 via email

@ndierckx
Copy link
Owner

ndierckx commented Jun 9, 2023

Hi, Will have a look if it is an easy fix..

@DenisGoryunov
Copy link
Author

DenisGoryunov commented Jun 9, 2023 via email

@DenisGoryunov
Copy link
Author

Hello Nicolas,

I'm wondering if there are any updates regarding the issue?

Regards,
Denis

@ndierckx
Copy link
Owner

Hi Denis,

Sorry I completely forgot about it. I think I fixed it today, will do some testruns tomorrow and then send you the new version.

Greets,

Nicolas

@DenisGoryunov
Copy link
Author

Hello Nicolas,

Thank you very much for your reply and the good news!

Regards,
Denis

@ndierckx
Copy link
Owner

I uploaded a new version (4.3.3), can you check if it works now ( it does for me)
Also download the config file again, because it is also updated..

You can now add output paths to the batch script now, it will make the folder and output the results in there....

@DenisGoryunov
Copy link
Author

Hello Nicolas,
Thanks a lot! I greatly appreciate your help and efforts! The file system of our HPC cluster is scanning for errors now. When it is finished, i will try to run the new Novoplasty version in batch mode to check the assemblies statistics.
Thank you again!

Regards,
Denis

@DenisGoryunov
Copy link
Author

DenisGoryunov commented Aug 9, 2023

Hello Nicolas,
I've tested the NOVOPlasty Version 4.3.3 on the same batch consisting of 57 samples.
Unfortunately, the "Organelle genome %" and "Average organelle coverage" metrics still permanently increase for each subsequent sample in the batch. It seems that the same is true for the "Aligned reads" and "Assembled reads" metrics.
Could you help me please?
If you leave me your email, i may send you privately the one large log file for all samples.
P.S. Output path is working in the batch mode now.
Regards,
Denis

@ndierckx
Copy link
Owner

Hi,

Ah sorry, I tested it once and it worked, so will have to take a look why it doesn't work for you...
You can find my mail on the home page of this repository..
You can send me the file..

greets,
Nicolas

@ndierckx
Copy link
Owner

Maybe send me the config file and batch file that you are using...

@ndierckx
Copy link
Owner

Think it is fixed now, could you try again with 4.3.4?

@DenisGoryunov
Copy link
Author

Hello Nicolas,
Thanks a lot! Do you need my log, config and batch file or should i try Novoplasty version 4.3.4 first?
Regards,
Denis

@ndierckx
Copy link
Owner

Maybe try 4.3.4 already, I think it should work now

@DenisGoryunov
Copy link
Author

Hello Nicolas,

NOVOPlasty Version 4.3.4 gives correct metrics on my batches.

Many thanks,
Denis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants