Support import gzip json file

[ndinh215]

No description provided.

[saimaz]

You can use zshortcut, it should be available. When we were discussing about shortcuts with multiple letters, the problem was that one of the letter was reserved, that's why there was a mistake with multiple. Since z is free it could be added. btw z in most of the unix commands means compressing.

[ndinh215]

Got it. Thanks @saimaz .

[saimaz]

In terms of implementation I have some concerns about isGzip variable passed through all classes. not sure yet is this a best way or there is another better one. @mvar @murnieza ?

[ndinh215]

Firstly, I did, I named it 'dataType', it could be XML, GZIP or any format. Then I thought 'isGzip' could reflect directly our expectation. For further extension, I think 'dataType' is OK.

[mvar]

@saimaz me too. What if in the future we need to add more options? Maybe we should pass $options array here?

@ndinh215 have you noticed, that you created this PR in your fork?

[ndinh215]

@mvar, this branch is based on the newest master in my repo. I still wait for the reviewing the issue ongr-io#535, then I will merge and then create new PR for this issue.

[murnieza]

I also think that all options (should we call it context?) should be passed around in one array but not separately.

[ndinh215]

So now, there are many names: 'options', 'context', 'params' ... for options array.
So which name do you prefer? @saimaz

[saimaz]

Maybe function should look loke this:

protected function getReader($manager, $filename, $convertDocuments, $options)

[ndinh215]

OK, thks @saimaz

[ndinh215]

I complemented this case with the param 'options'. Could you please review again these changes before I merge and create a new PR to ongr-io repo?@saimaz
Thanks.