Add the option '--if-not-exists' in the command 'ongr:es:index:create'

[ndinh215]

I fixed the issue #423 . Please review again. Thanks.

[murnieza]

I think that Symfony does not support multi-letter input option shortcuts. I see that we have the same with other options

[ndinh215]

http://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html
With this standard, it could understand wrong the options.

[saimaz]

I'm not sure 100% but probably better would be change to: return 0;.

[ndinh215]

You are correct. As Doctrine's code about this processing, it will be

return $error ? 1 : 0;

whatever success or error.

Hence, here, we agree that 0 will be for fail and 1 for success. Is it OK? @saimaz

[saimaz]

You should not use different test case data provider and try to behave inside test case to match expectations. To test --if-not-exists please write separate test case, the data provider is not necessary.

[ndinh215]

Thanks for your points, @saimaz . With this patch, I removed try catch and added asserts for testing result which is returned from the execution and the output string. And also, I refactored the code a bit for the purpose of retrieving command tester (for testing output in terminal) via the method:

protected function getCommandTester($commandName)
    {
        $app = new Application();
        $app->add($this->getCreateCommand());

        $command = $app->find($commandName);
        $commandTester = new CommandTester($command);

        return $commandTester;
    }

About the data provider, I think this test case still needs it because at present the test case does not try to catch the Elasticsearch exception of 'Index already exists', it tries to assert the returns from command execution.

[mvar]

Index is automatically created when you call $this->getManager().

[ndinh215]

Closes #423

[ndinh215]

I will create new PR with better form for this issue.