Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate sum on binary list #1600

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

jvoigtlaender
Copy link
Contributor

Seen in student code.

(Of course, similar evaluation rules like sum [x] -> x could also be added. But this is the one I have really seen.)

@jvoigtlaender
Copy link
Contributor Author

The new hint is also in the spirit of existing ones like these:

hlint/data/hlint.yaml

Lines 132 to 133 in 752baba

- warn: {lhs: "maximum [a, b]", rhs: max a b}
- warn: {lhs: "minimum [a, b]", rhs: min a b}

@ndmitchell ndmitchell merged commit 0c87d36 into ndmitchell:master Aug 26, 2024
0 of 5 checks passed
@ndmitchell
Copy link
Owner

Thanks!

ndmitchell added a commit that referenced this pull request Aug 26, 2024
Summary:

Test Plan:
@jvoigtlaender jvoigtlaender deleted the sum-list branch August 26, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants