Do not use isSet in isUsed functions

[johannes-wolf]

Please check contribution guide first.

Description

The is*Set() functions are generated for -withWriterCode only, but are used without
further checking in is*Used() which results in non compiling code if using optional fields with -withoutWriterCode.

Always generate is*Set() for optional fields.
Alternative would be changing the expression, the C++, Java and Python generators generate for optionals <type> members to not call is*Set()
but test the optional directly.

The line triggering this bug in the Structure*.ftl files is (example from the Python generator, line 304):

def ${field.optional.isUsedIndicatorName}(self) -> bool:
  ...
  return <#if field.optional.clause??>${field.optional.clause}<#else>self.${field.optional.isSetIndicatorName}()</#if>

I've added an unused optional ... field to one of the test-structs, that triggers the bug without this change.

Type of Change

• Bug fix
• New feature
• Documentation enhancement

[mikir]

Thanks for that! Your fix for all generators s correct and it will be accepted without any further changes.

I just need to improve without_writer_code integration test a little bit more to check that added structure is really immutable (no non-const methods are generated).

Because I don't have access to your branch, I will create a new branch accepting there this PR and continue. OK?

[johannes-wolf]

Thanks for that! Your fix for all generators s correct and it will be accepted without any further changes.

I just need to improve without_writer_code integration test a little bit more to check that added structure is really immutable (no non-const methods are generated).

Because I don't have access to your branch, I will create a new branch accepting there this PR and continue. OK?

OK 👍.