Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release httptest 4.0.0 #53

Closed
16 of 18 tasks
nealrichardson opened this issue Nov 25, 2020 · 3 comments
Closed
16 of 18 tasks

Release httptest 4.0.0 #53

nealrichardson opened this issue Nov 25, 2020 · 3 comments

Comments

@nealrichardson
Copy link
Owner

nealrichardson commented Nov 25, 2020

cc @jonkeane @maelle

There are a few new features, plus better support for testthat 3rd edition, so a release would be good.

Checklist:

@maelle
Copy link
Contributor

maelle commented Nov 26, 2020

Thanks for adding me as contributor, I appreciate it 🙏

So #49 is out-of-scope for this release?

Reg #43 I think it'd just be a matter of copy-pasting from other sources so could be done before release? (your blog post, https://github.com/ropensci-books/http-testing/pull/47/files#diff-d7ac0bbc0eb16d66139463bc6fd3b5fa861fd15ef8903ef4eb9276072d29610f) Well, if deemed useful, of course. :-)

@nealrichardson
Copy link
Owner Author

So #49 is out-of-scope for this release?

I think it would be nice to have, but I don't know how trivial it is going to be, and I don't have a ton of time to work on this going forward (was taking advantage of a few days off of work to catch up here). I'll give it some thought and see if it comes together, but I don't think it needs to block releasing the rest of the improvements

Reg #43 I think it'd just be a matter of copy-pasting from other sources so could be done before release?

Added to the checklist, thanks.

@nealrichardson
Copy link
Owner Author

Submitted to CRAN. I did not get to #43 but we can pick it up after the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants