Replace httptest::with_mock_API with with_mock_api #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 23 23
Lines 837 837
=======================================
Hits 770 770
Misses 67 67 Continue to review full report at Codecov.
|
|
Ended up manually applying due to repo oddness - submitted to CRAN as part of edgarWebR 1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three years ago, several functions were renamed in the
httptest3.0.0 release for consistency withhttrandtestthat. Function aliases with the old naming were kept to avoid breaking packages, but in the upcominghttptest4.0.0 release, these deprecated functions are being removed. This PR updates your package to use the functions that will remain in the 4.0.0 release.We plan to submit the
httptestupdate to CRAN at the end of January. To avoid any potential nastygrams from CRAN, it would be ideal if you can update your package on CRAN with this change before then. Thanks!