Various fixes to interactive test running #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 435 445 +10
=========================================
+ Hits 435 445 +10
Continue to review full report at Codecov.
|
|
Awesome! Any wisdom to add to hadley/r-pkgs#483? 🙂 |
This was referenced Nov 25, 2020
Closed
nealrichardson
added a commit
that referenced
this pull request
Dec 21, 2020
* Various fixes to interactive test running * Update docs * Try to test devtools::test on GHA * Fail the build if devtools::test fails * Better detection of load_all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47. You can now run tests interactively with
devtools::test().The issues were:
public()doesn't really work when you've loaded the package withpkgload::load_all()because everything is put in the global environment, so we can't test that it catches when you try to call unexported functions. One skip added.pkgloadis also loaded (as a special case so that you can develop a redactor for your package interactively). This is fine when running the tests withoutdevtools, but when you do,pkgloadis on the search path so the logic was wrong (and you can't detachpkgloadas one of the teardowns tried.)devtools::test()to pass, a second run in the same R process would fail.I've also added a GitHub Actions job that runs the tests with
devtools::test()(twice, in fact) so that we don't regress on this.cc @maelle @jonkeane